-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table: standalone implement for table.MutateContext
and table.AllocatorContext
#51262
Conversation
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51262 +/- ##
=================================================
- Coverage 70.7007% 54.8490% -15.8518%
=================================================
Files 1457 1568 +111
Lines 433745 602802 +169057
=================================================
+ Hits 306661 330631 +23970
- Misses 107895 249167 +141272
- Partials 19189 23004 +3815
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #51259
What changed and how does it work?
We have introduced a standalone implement for
PlanContext
in #51237. In this PR, we continue to decouple the implement oftable.MutateContext
with session. After this PR,sessionctx.Context
does not need to declare all methods inMutateContext
and it exposes a new methodGetTableContext
to return the table context.A new package
pkg/table/contextimpl
is introduced to implement its own methods inMutateContext
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.