Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table: standalone implement for table.MutateContext and table.AllocatorContext #51262

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Feb 23, 2024

What problem does this PR solve?

Issue Number: close #51259

What changed and how does it work?

We have introduced a standalone implement for PlanContext in #51237. In this PR, we continue to decouple the implement of table.MutateContext with session. After this PR, sessionctx.Context does not need to declare all methods in MutateContext and it exposes a new method GetTableContext to return the table context.

A new package pkg/table/contextimpl is introduced to implement its own methods in MutateContext.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 23, 2024
Copy link

tiprow bot commented Feb 23, 2024

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Merging #51262 (4d8d432) into master (5b187e5) will decrease coverage by 15.8518%.
Report is 5 commits behind head on master.
The diff coverage is 92.6829%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51262         +/-   ##
=================================================
- Coverage   70.7007%   54.8490%   -15.8518%     
=================================================
  Files          1457       1568        +111     
  Lines        433745     602802     +169057     
=================================================
+ Hits         306661     330631      +23970     
- Misses       107895     249167     +141272     
- Partials      19189      23004       +3815     
Flag Coverage Δ
integration 36.9461% <69.5122%> (?)
unit 70.3613% <91.4634%> (-0.1345%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.3481% <100.0000%> (+5.4715%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 23, 2024
Copy link

ti-chi-bot bot commented Feb 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 23, 2024
Copy link

ti-chi-bot bot commented Feb 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-23 06:09:37.282619626 +0000 UTC m=+596666.030242735: ☑️ agreed by tangenta.
  • 2024-02-23 06:50:08.536672416 +0000 UTC m=+599097.284295527: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit fc36864 into pingcap:master Feb 23, 2024
34 of 43 checks passed
@lcwangchao lcwangchao deleted the tbctximpl branch February 23, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support to implement table.MutateContext to separate package outside session
3 participants