Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experssion: table: standalone implement for EvalContext and BuildContext #51299

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #51298

What changed and how does it work?

After this PR, we do not need to require sessionctx.Context to implement expression.EvalContext/BuildContext. So the expression contexts can have their implementations outside the session package.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 26, 2024
Copy link

tiprow bot commented Feb 26, 2024

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Merging #51299 (51c0062) into master (fc36864) will increase coverage by 0.6081%.
Report is 19 commits behind head on master.
The diff coverage is 88.8217%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51299        +/-   ##
================================================
+ Coverage   72.3575%   72.9657%   +0.6081%     
================================================
  Files          1459       1462         +3     
  Lines        361227     438347     +77120     
================================================
+ Hits         261375     319843     +58468     
- Misses        80553      98708     +18155     
- Partials      19299      19796       +497     
Flag Coverage Δ
integration 49.4185% <71.2990%> (?)
unit 70.6224% <83.3836%> (-1.5806%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 51.4035% <100.0000%> (+5.0170%) ⬆️

@lcwangchao lcwangchao force-pushed the exprctximpl branch 2 times, most recently from 0321960 to 78db75c Compare February 26, 2024 03:09
@lcwangchao
Copy link
Collaborator Author

/retest

Copy link

tiprow bot commented Feb 26, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 26, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 27, 2024
Copy link

ti-chi-bot bot commented Feb 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 12:26:26.462506971 +0000 UTC m=+878475.210130082: ☑️ agreed by YangKeao.
  • 2024-02-27 05:18:42.4514364 +0000 UTC m=+939211.199059510: ☑️ agreed by XuHuaiyu.

Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

for lightning/import part

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for ddl part

Copy link

ti-chi-bot bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta, XuHuaiyu, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 27, 2024
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 6f02e99 into pingcap:master Feb 27, 2024
31 checks passed
@lcwangchao lcwangchao deleted the exprctximpl branch February 27, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support to implement expression.EvalContext in separate packages outside sessionctx
6 participants