-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: introduce a interface for binding cache #51351
Conversation
Hi @qw4990. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
// SetBinding sets the binding for the specified sqlDigest. | ||
SetBinding(sqlDigest string, meta Bindings) (err error) | ||
// RemoveBinding removes the binding for the specified sqlDigest. | ||
RemoveBinding(sqlDigest string) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe UnsetBingding
is better. But I am OK with it. Feel free to leave it.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, hi-rustin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@qw4990: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51351 +/- ##
================================================
+ Coverage 70.5875% 72.8792% +2.2917%
================================================
Files 1460 1462 +2
Lines 434721 438897 +4176
================================================
+ Hits 306859 319865 +13006
+ Misses 108571 98912 -9659
- Partials 19291 20120 +829
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: ref #51347
Problem Summary: planner: introduce a interface for binding cache
What changed and how does it work?
NO LOGICAL CHANGE, JUST ADD A INTERFACE.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.