Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: introduce a interface for binding cache #51351

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Feb 27, 2024

What problem does this PR solve?

Issue Number: ref #51347

Problem Summary: planner: introduce a interface for binding cache

What changed and how does it work?

NO LOGICAL CHANGE, JUST ADD A INTERFACE.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2024
Copy link

tiprow bot commented Feb 27, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990 qw4990 added the sig/planner SIG: Planner label Feb 27, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 27, 2024
// SetBinding sets the binding for the specified sqlDigest.
SetBinding(sqlDigest string, meta Bindings) (err error)
// RemoveBinding removes the binding for the specified sqlDigest.
RemoveBinding(sqlDigest string)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe UnsetBingding is better. But I am OK with it. Feel free to leave it.

Copy link

ti-chi-bot bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 27, 2024
Copy link

ti-chi-bot bot commented Feb 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-27 07:32:36.018649289 +0000 UTC m=+947244.766272400: ☑️ agreed by hawkingrei.
  • 2024-02-27 07:36:18.375512685 +0000 UTC m=+947467.123135796: ☑️ agreed by hi-rustin.

Copy link

tiprow bot commented Feb 27, 2024

@qw4990: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test e4123d0 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qw4990
Copy link
Contributor Author

qw4990 commented Feb 27, 2024

/retest

Copy link

tiprow bot commented Feb 27, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Merging #51351 (50309b1) into master (801de42) will increase coverage by 2.2917%.
Report is 10 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51351        +/-   ##
================================================
+ Coverage   70.5875%   72.8792%   +2.2917%     
================================================
  Files          1460       1462         +2     
  Lines        434721     438897      +4176     
================================================
+ Hits         306859     319865     +13006     
+ Misses       108571      98912      -9659     
- Partials      19291      20120       +829     
Flag Coverage Δ
integration 49.0521% <100.0000%> (?)
unit 70.3448% <100.0000%> (-0.0334%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.2905% <ø> (+5.4609%) ⬆️

@qw4990
Copy link
Contributor Author

qw4990 commented Feb 27, 2024

/retest

Copy link

tiprow bot commented Feb 27, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit c663937 into pingcap:master Feb 27, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants