Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: wait until binding is loaded into memory if binding cache miss #51400

Merged
merged 3 commits into from
Mar 6, 2024
Merged

planner: wait until binding is loaded into memory if binding cache miss #51400

merged 3 commits into from
Mar 6, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Feb 28, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #51347

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2024
@hawkingrei hawkingrei marked this pull request as draft February 28, 2024 10:29
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2024
@hawkingrei hawkingrei marked this pull request as ready for review February 28, 2024 10:34
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Feb 28, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 29, 2024 •
edited
Loading

Codecov Report

Merging #51400 (881e1c9) into master (5d9a81c) will increase coverage by 0.4280%.
Report is 5 commits behind head on master.
The diff coverage is 61.7284%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #51400        +/-   ##
================================================
+ Coverage   72.4707%   72.8988%   +0.4280%     
================================================
  Files          1464       1464                
  Lines        362320     436542     +74222     
================================================
+ Hits         262576     318234     +55658     
- Misses        80376      98362     +17986     
- Partials      19368      19946       +578
Flag Coverage Δ
integration 49.0278% <56.7901%> (?)
unit 70.5880% <61.7284%> (-1.7415%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 51.4205% <ø> (+5.0338%) ⬆️

@hawkingrei hawkingrei force-pushed the wait_util_get_binding branch 2 times, most recently from 76d80a3 to 5f2545d Compare February 29, 2024 14:47
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei force-pushed the wait_util_get_binding branch from ea0b4a2 to d047da3 Compare March 1, 2024 06:32
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei force-pushed the wait_util_get_binding branch from d047da3 to a8768bc Compare March 1, 2024 07:03
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 1, 2024
@hawkingrei hawkingrei force-pushed the wait_util_get_binding branch from 5d62e2f to d09bcad Compare March 1, 2024 10:58
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 1, 2024
@hawkingrei hawkingrei force-pushed the wait_util_get_binding branch from d8027c8 to 8b8d78c Compare March 4, 2024 04:19
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei force-pushed the wait_util_get_binding branch from 8b8d78c to c73446d Compare March 4, 2024 05:43
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei requested a review from qw4990 March 5, 2024 09:03
@hawkingrei
Copy link
Member Author

@qw4990 PTAL

@qw4990 qw4990 mentioned this pull request Mar 6, 2024
Open
18 tasks
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 6, 2024
@hawkingrei
planner: wait until binding is loaded into memory if binding cache miss
24d5753 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
planner: wait until binding is loaded into memory if binding cache miss
7f2d6ce 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei force-pushed the wait_util_get_binding branch from 47cd0f3 to 7f2d6ce Compare March 6, 2024 03:52
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei requested a review from elsa0520 March 6, 2024 04:14
AilinKid
AilinKid reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

pkg/bindinfo/global_handle.go Outdated Show resolved Hide resolved
@hawkingrei
update
881e1c9 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 6, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-06 03:46:58.028144957 +0000 UTC m=+225245.050391345: ☑️ agreed by qw4990.
  • 2024-03-06 06:29:58.867101444 +0000 UTC m=+235025.889347831: ☑️ agreed by AilinKid.

@qw4990
Copy link
Contributor

qw4990 commented Mar 6, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 0878b15 into pingcap:master Mar 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@qw4990 qw4990 qw4990 approved these changes

@elsa0520 elsa0520 Awaiting requested review from elsa0520

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawkingrei @qw4990 @AilinKid