-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: add more metrics for binding #51739
Conversation
Hi @qw4990. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -18,16 +18,48 @@ import "github.com/prometheus/client_golang/prometheus" | |||
|
|||
// bindinfo metrics. | |||
var ( | |||
BindUsageCounter *prometheus.CounterVec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useless, just remove it
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51739 +/- ##
================================================
+ Coverage 72.4732% 72.6866% +0.2133%
================================================
Files 1475 1475
Lines 363671 438737 +75066
================================================
+ Hits 263564 318903 +55339
- Misses 80719 99783 +19064
- Partials 19388 20051 +663
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@hawkingrei: Your lgtm message is repeated, so it is ignored. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, hi-rustin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
2 similar comments
/retest |
/retest |
What problem does this PR solve?
Issue Number: ref #51347
Problem Summary: planner: add more metrics for binding
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.