Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: output a SQL warning if binding loading is triggered #51774

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Mar 14, 2024

What problem does this PR solve?

Issue Number: ref #51347

Problem Summary: planner: output a SQL warning if binding loading is triggered

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 14, 2024
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 14, 2024
Copy link

tiprow bot commented Mar 14, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 14, 2024
Copy link

ti-chi-bot bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 14, 2024
Copy link

ti-chi-bot bot commented Mar 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-14 07:38:12.360568513 +0000 UTC m=+930319.382814896: ☑️ agreed by hawkingrei.
  • 2024-03-14 07:39:49.962662388 +0000 UTC m=+930416.984908771: ☑️ agreed by hi-rustin.

@qw4990
Copy link
Contributor Author

qw4990 commented Mar 14, 2024

/retest

Copy link

tiprow bot commented Mar 14, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.9812%. Comparing base (c95a54c) to head (f4794ef).
Report is 1571 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51774        +/-   ##
================================================
+ Coverage   70.7160%   72.9812%   +2.2652%     
================================================
  Files          1476       1476                
  Lines        437502     441675      +4173     
================================================
+ Hits         309384     322340     +12956     
+ Misses       108721      99235      -9486     
- Partials      19397      20100       +703     
Flag Coverage Δ
integration 48.9233% <75.0000%> (?)
unit 70.6010% <75.0000%> (+0.0694%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.7529% <ø> (+5.8492%) ⬆️

@qw4990
Copy link
Contributor Author

qw4990 commented Mar 14, 2024

/retest

Copy link

tiprow bot commented Mar 14, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Mar 14, 2024
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 14, 2024

/retest

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 14, 2024

/retest

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2024
@@ -234,31 +234,6 @@ INSERT INTO t0(c0) VALUES (3);
SELECT /*+ MERGE_JOIN(t1, t0, v0)*/v0.c2, t1.c0 FROM v0, t0 CROSS JOIN t1 ORDER BY -v0.c1;


# TestInvisibleIndex
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unstable and duplicated with bindinfo/test/TestInvisibleIndex, just remove it.

@qw4990
Copy link
Contributor Author

qw4990 commented Mar 15, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit fcdf565 into pingcap:master Mar 15, 2024
23 checks passed
@qw4990 qw4990 added the type/bugfix This PR fixes a bug. label Oct 9, 2024
@qw4990 qw4990 removed the type/bugfix This PR fixes a bug. label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants