Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: Fix PointGet HandleColOffset #51796

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Mar 14, 2024

What problem does this PR solve?

Issue Number: close #51797, close #51761

Problem Summary:
The HandleColOffset in PointGetPlan was not correctly set, resulting in checking the wrong column's value for partitioning pruning.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2024
Copy link

tiprow bot commented Mar 14, 2024

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Merging #51796 (a5bff65) into master (0ed511a) will increase coverage by 0.2472%.
Report is 16 commits behind head on master.
The diff coverage is 40.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51796        +/-   ##
================================================
+ Coverage   72.5318%   72.7790%   +0.2472%     
================================================
  Files          1476       1476                
  Lines        364152     437780     +73628     
================================================
+ Hits         264126     318612     +54486     
- Misses        80647      99106     +18459     
- Partials      19379      20062       +683     
Flag Coverage Δ
integration 48.6586% <40.0000%> (?)
unit 70.4837% <40.0000%> (-1.9386%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 51.4236% <ø> (+4.9262%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 15, 2024
@Defined2014 Defined2014 requested review from YangKeao and xhebox March 15, 2024 06:06
Copy link

ti-chi-bot bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 15, 2024
Copy link

ti-chi-bot bot commented Mar 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-15 03:17:37.720179181 +0000 UTC m=+1001084.742425570: ☑️ agreed by Defined2014.
  • 2024-03-15 06:57:13.46126717 +0000 UTC m=+1014260.483513558: ☑️ agreed by xhebox.

Copy link

tiprow bot commented Mar 15, 2024

@mjonss: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow a5bff65 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 1139439 into pingcap:master Mar 15, 2024
22 of 23 checks passed
@mjonss mjonss deleted the fix-pointget-handlecoloffset branch March 15, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partition pruning get wrong partition for PointGet with single int column PK data residue after batch delete
3 participants