Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: skip CREATE DATABASE when downstream exists, and return error when parse failed (#51801) #52065

Merged
merged 16 commits into from
Apr 2, 2024
Merged

lightning: skip CREATE DATABASE when downstream exists, and return error when parse failed (#51801) #52065

merged 16 commits into from
Apr 2, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51801

What problem does this PR solve?

Issue Number: close #51800

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#51801
6087a8b 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Mar 25, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 25, 2024
Merged
13 tasks
@lance6716
fix some
f31e2d1 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix some
db3e39a 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix some
ec3970a 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2024
@lance6716
fix mock
2555563 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix
3ce5304 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix bazel
7f29e6e 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 29, 2024
@lance6716
fix build
cf58c3d 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix build
3144971 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix build
e0bb356 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix build
6d335d9 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix UT
366ee6a 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix UT
0e8c7c9 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix fmt
3dd871f 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix
404f48d 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix bazel
00b9d9e 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 29, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 29, 2024 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@4d3fe3d). Click here to learn what that means.
The diff coverage is 41.2500%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #52065   +/-   ##
================================================
  Coverage               ?   73.7544%           
================================================
  Files                  ?       1096           
  Lines                  ?     351995           
  Branches               ?          0           
================================================
  Hits                   ?     259612           
  Misses                 ?      75779           
  Partials               ?      16604

GMHDBJD
GMHDBJD approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 29, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 29, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-29 09:47:31.378669594 +0000 UTC m=+5312.906210142: ☑️ agreed by lance6716.
  • 2024-03-29 10:07:31.755776615 +0000 UTC m=+6513.283317161: ☑️ agreed by GMHDBJD.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 1, 2024
@GMHDBJD
Copy link
Contributor

GMHDBJD commented Apr 1, 2024

/retest

@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Apr 2, 2024
@lance6716
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 9815b45 into pingcap:release-6.5 Apr 2, 2024
28 checks passed
@wuhuizuo wuhuizuo deleted the cherry-pick-51801-to-release-6.5 branch April 2, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees

@GMHDBJD GMHDBJD

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @GMHDBJD @lance6716