Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: move scan-split-scatter regions logic into common package #52399

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Apr 8, 2024

What problem does this PR solve?

Issue Number: ref #51533

Problem Summary:

What changed and how does it work?

the split package now have a new method to scan, split and scatter region based on given sorted keys.

BR will use this new interface in next PR.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 8, 2024
Copy link

tiprow bot commented Apr 8, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 8, 2024
@lance6716
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed do-not-merge/needs-tests-checked labels Apr 8, 2024
@lance6716
Copy link
Contributor Author

/test pull-lightning-integration-test

@lance6716 lance6716 changed the title [WIP]lightning: move split multiple regions logic into common package lightning: move split multiple regions logic into common package Apr 8, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2024
Copy link

tiprow bot commented Apr 8, 2024

@lance6716: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Merging #52399 (4b220c7) into master (29ced7f) will increase coverage by 0.2446%.
Report is 13 commits behind head on master.
The diff coverage is 82.3529%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52399        +/-   ##
================================================
+ Coverage   74.1411%   74.3858%   +0.2446%     
================================================
  Files          1467       1467                
  Lines        354227     428306     +74079     
================================================
+ Hits         262628     318599     +55971     
- Misses        72389      89838     +17449     
- Partials      19210      19869       +659     
Flag Coverage Δ
integration 48.7813% <75.4902%> (?)
unit 71.0023% <67.6470%> (-1.8939%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 49.7968% <81.6326%> (+7.3631%) ⬆️

@lance6716 lance6716 changed the title lightning: move split multiple regions logic into common package lightning: move scan-split-scatter regions logic into common package Apr 8, 2024
"github.com/pingcap/tidb/pkg/lightning/common"
"github.com/pingcap/tidb/pkg/lightning/config"
brlog "github.com/pingcap/tidb/pkg/lightning/log"
util2 "github.com/pingcap/tidb/pkg/util"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
util2 "github.com/pingcap/tidb/pkg/util"
tidbutil "github.com/pingcap/tidb/pkg/util"

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 8, 2024
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 9, 2024
Copy link

ti-chi-bot bot commented Apr 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-08 09:42:40.123132031 +0000 UTC m=+869021.650672574: ☑️ agreed by D3Hunter.
  • 2024-04-09 02:06:31.508365611 +0000 UTC m=+928053.035906158: ☑️ agreed by tangenta.

Copy link

ti-chi-bot bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, tangenta, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit a0b5861 into pingcap:master Apr 9, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants