-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: move scan-split-scatter regions logic into common package #52399
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test pull-lightning-integration-test |
@lance6716: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52399 +/- ##
================================================
+ Coverage 74.1411% 74.3858% +0.2446%
================================================
Files 1467 1467
Lines 354227 428306 +74079
================================================
+ Hits 262628 318599 +55971
- Misses 72389 89838 +17449
- Partials 19210 19869 +659
Flags with carried forward coverage won't be shown. Click here to find out more.
|
br/pkg/restore/split/client.go
Outdated
"github.com/pingcap/tidb/pkg/lightning/common" | ||
"github.com/pingcap/tidb/pkg/lightning/config" | ||
brlog "github.com/pingcap/tidb/pkg/lightning/log" | ||
util2 "github.com/pingcap/tidb/pkg/util" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
util2 "github.com/pingcap/tidb/pkg/util" | |
tidbutil "github.com/pingcap/tidb/pkg/util" |
Signed-off-by: lance6716 <lance6716@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, tangenta, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #51533
Problem Summary:
What changed and how does it work?
the
split
package now have a new method to scan, split and scatter region based on given sorted keys.BR will use this new interface in next PR.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.