br: use common scan-split-scatter logic

[lance6716]

What problem does this PR solve?

Issue Number: ref #51533

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
  BR CI https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fpull_br_integration_test/detail/pull_br_integration_test/102/pipeline
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[lance6716]

/test pull-br-integration-test

[tiprow]

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #52433 (6505cac) into master (a0b5861) will increase coverage by 2.8886%.
Report is 15 commits behind head on master.
The diff coverage is 79.3103%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #52433        +/-   ##
================================================
+ Coverage   72.1392%   75.0279%   +2.8886%     
================================================
  Files          1467       1467                
  Lines        426844     427329       +485     
================================================
+ Hits         307922     320616     +12694     
+ Misses        99686      86516     -13170     
- Partials      19236      20197       +961     

Flag	Coverage Δ
integration	50.0133% <67.2413%> (?)
unit	71.0056% <41.3793%> (-0.0074%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	59.4671% <78.9473%> (+18.3921%)	⬆️

[lance6716]

/ok-to-test

[lance6716]

/test pull-br-integration-test

[tiprow]

@lance6716: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lance6716]

/test pull-br-integration-test

[tiprow]

@lance6716: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[3pointer]

scanStartKey is the start key. but sortedKeys are all end keys. if didn't scan with start key will cause error.

[lance6716]

we don't need to split the scanStartKey so theoretically we don't need to care about it. For the error I should have fixed in

tidb/br/pkg/restore/split/client.go

Lines 541 to 548 in da775f6

	// we need to find the regions that contain the split keys. However, the scan
	// region API accepts a key range [start, end) where end key is exclusive, and if
	// sortedSplitKeys length is 1, we scan region may return empty result. So we
	// increase the end key a bit. If the end key is on the region boundaries, it
	// will be skipped by getSplitKeysOfRegions.
	scanStart := codec.EncodeBytesExt(nil, sortedSplitKeys[0], c.isRawKv)
	lastKey := kv.Key(sortedSplitKeys[len(sortedSplitKeys)-1])
	scanEnd := codec.EncodeBytesExt(nil, lastKey.Next(), c.isRawKv)

[lance6716]

update: I fixed a bug and add tests in 59e6f0f

[3pointer]

Okay, We need make sure not use same key as start/end key to scan regions. or we will get an error from PD. I assume here is no chance to get a slice with only one nil/"" value in it.

[ti-chi-bot]

@lance6716: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-br-integration-test	6505cac	link	true	/test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Leavrth]

Now it can directly call regionSplitter.client.SplitWaitAndScatter and the function splitAndScatterRegions can be removed.

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-04-10 03:24:53.823554522 +0000 UTC m=+1019155.351095085: ☑️ agreed by Leavrth.
• 2024-04-10 03:43:36.899534537 +0000 UTC m=+1020278.427075083: ☑️ agreed by 3pointer.

[lance6716]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, lance6716, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• br/OWNERS [3pointer,Leavrth]
• pkg/lightning/OWNERS [lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment