planner: move base plan related output of core pkg and make it well-pkged

[AilinKid]

What problem does this PR solve?

Issue Number: ref #51664

Problem Summary:

What changed and how does it work?

move plan_base.go from core/ to core/base/
since PhysicalPlan definition depends on Task, we should move Task interface definition core/base/ here too
The general Task definition shouldn't rely on any concrete TaskImpl, so I remove the *RootTask as the return type inside Task interface.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AilinKid]

/hold

[hawkingrei]

/ok-to-test

[AilinKid]

/unhold

[AilinKid]

/test unit-test

[tiprow]

@AilinKid: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #52529 (6351bfb) into master (3fff0f2) will increase coverage by 0.0914%.
Report is 11 commits behind head on master.
The diff coverage is 96.7142%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #52529        +/-   ##
================================================
+ Coverage   74.1426%   74.2340%   +0.0914%     
================================================
  Files          1470       1470                
  Lines        354534     429389     +74855     
================================================
+ Hits         262861     318753     +55892     
- Misses        72435      90738     +18303     
- Partials      19238      19898       +660     

Flag	Coverage Δ
integration	48.9344% <82.1428%> (?)
unit	71.1925% <95.4285%> (-1.7113%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (-2.3014%)	⬇️
parser	∅ <ø> (∅)
br	49.7359% <ø> (+7.0959%)	⬆️

[Rustin170506]

It seems we don't need to rename it.

[Rustin170506]

Can I ask why do we need to rename here?

[AilinKid]

there is another core pkg in the import list here, oh! for this file, its not, I will change it back to base

[AilinKid]

nice catch

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-04-12 06:41:46.836802372 +0000 UTC m=+1203768.364342917: ☑️ agreed by hawkingrei.
• 2024-04-15 09:42:07.761223769 +0000 UTC m=+244746.872270218: ☑️ agreed by Defined2014.

[lance6716]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei, hi-rustin, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Defined2014,hawkingrei,hi-rustin,lance6716]
• pkg/executor/importer/OWNERS [lance6716]
• pkg/planner/OWNERS [hawkingrei,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment