Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: send backup request in batch #52535

Merged
merged 7 commits into from
May 7, 2024

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Apr 12, 2024

What problem does this PR solve?

Issue Number: ref #52534

Problem Summary:
The BackupRequest contains the key range of index or small partition, whose kv data is only distributed in few regions.

What changed and how does it work?

send backup request in batch.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Apr 12, 2024
Copy link

tiprow bot commented Apr 12, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 75.80645% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 74.3944%. Comparing base (b66a85c) to head (0bdd67e).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52535        +/-   ##
================================================
+ Coverage   72.0405%   74.3944%   +2.3539%     
================================================
  Files          1508       1514         +6     
  Lines        434733     455363     +20630     
================================================
+ Hits         313184     338765     +25581     
+ Misses       102012      95228      -6784     
- Partials      19537      21370      +1833     
Flag Coverage Δ
integration 29.5993% <72.9838%> (?)
unit 71.2276% <26.2096%> (-0.0219%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 55.8760% <75.8064%> (+17.5251%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 29, 2024
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

br/pkg/backup/client.go Outdated Show resolved Hide resolved
br/pkg/rtree/rtree.go Outdated Show resolved Hide resolved
br/pkg/rtree/rtree.go Outdated Show resolved Hide resolved
br/pkg/rtree/rtree.go Outdated Show resolved Hide resolved
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Copy link

ti-chi-bot bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 7, 2024
Copy link

ti-chi-bot bot commented May 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-29 09:48:35.518174416 +0000 UTC m=+264269.275309991: ☑️ agreed by 3pointer.
  • 2024-05-07 03:57:45.850342235 +0000 UTC m=+934419.607477808: ☑️ agreed by YuJuncen.

@Leavrth
Copy link
Contributor Author

Leavrth commented May 7, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label May 7, 2024
@Leavrth
Copy link
Contributor Author

Leavrth commented May 7, 2024

/retest

1 similar comment
@Leavrth
Copy link
Contributor Author

Leavrth commented May 7, 2024

/retest

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot merged commit 81da4f8 into pingcap:master May 7, 2024
21 of 22 checks passed
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants