Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: Enable checkpoint advancer to pause tasks lagged too large (#51441) #52555

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51441

What problem does this PR solve?

Issue Number: close #50803

Problem Summary:

What changed and how does it work?

Now, a new option called CheckPointLagLimit is added to the advancer config. When it is set, advancer will check if the checkpoint is lagged too large on every tick. If so, advancer would send a warning to PD and unstall the task.
PS: Theoretically, we need a resume signal when the task could be resumed. However, there is no channel to send this signal now. Maybe we will add it in the future.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

A new option called `CheckPointLagLimit` is added to the advancer config. When it is set, advancer will check if the checkpoint is lagged too large on every tick. If so, advancer would send a warning to PD and unstall the task.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 58.76289% with 40 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@f3f5b69). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #52555   +/-   ##
================================================
  Coverage               ?   72.1045%           
================================================
  Files                  ?       1412           
  Lines                  ?     411505           
  Branches               ?          0           
================================================
  Hits                   ?     296714           
  Misses                 ?      94879           
  Partials               ?      19912           
Flag Coverage Δ
unit 72.1045% <58.7628%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.5105% <0.0000%> (?)

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 6, 2024
@BornChanger
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 24, 2024
@RidRisR
Copy link
Contributor

RidRisR commented May 27, 2024

/test unit-test

Copy link

tiprow bot commented May 27, 2024

@RidRisR: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label May 27, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 8, 2024
Copy link

ti-chi-bot bot commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 11, 2024
Copy link

ti-chi-bot bot commented Jul 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-24 15:05:40.698693196 +0000 UTC m=+2443294.455828761: ☑️ agreed by BornChanger.
  • 2024-07-11 05:25:25.997872903 +0000 UTC m=+508023.233107015: ☑️ agreed by YuJuncen.

@RidRisR
Copy link
Contributor

RidRisR commented Jul 11, 2024

/test unit-test

Copy link

tiprow bot commented Jul 11, 2024

@RidRisR: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RidRisR
Copy link
Contributor

RidRisR commented Jul 12, 2024

/test unit-test

Copy link

tiprow bot commented Jul 12, 2024

@RidRisR: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RidRisR
Copy link
Contributor

RidRisR commented Jul 12, 2024

/test unit-test

Copy link

tiprow bot commented Jul 12, 2024

@RidRisR: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@YuJuncen
Copy link
Contributor

/test unit-test

Copy link

tiprow bot commented Jul 15, 2024

@YuJuncen: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 2907089 into pingcap:release-7.5 Jul 15, 2024
33 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants