-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix incorrect truncate table
's scheme_ids
#52591
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52591 +/- ##
================================================
+ Coverage 72.2344% 74.3923% +2.1578%
================================================
Files 1469 1470 +1
Lines 427098 432387 +5289
================================================
+ Hits 308512 321663 +13151
+ Misses 99447 90754 -8693
- Partials 19139 19970 +831
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52591 +/- ##
================================================
+ Coverage 72.2344% 73.8104% +1.5759%
================================================
Files 1469 1473 +4
Lines 427098 441355 +14257
================================================
+ Hits 308512 325766 +17254
+ Misses 99447 95511 -3936
- Partials 19139 20078 +939
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
What problem does this PR solve?
Issue Number: close #52589
Problem Summary:
Didn't handle the schema id for
truncate table
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.