Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix incorrect truncate table's scheme_ids #52591

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Apr 12, 2024

What problem does this PR solve?

Issue Number: close #52589

Problem Summary:
Didn't handle the schema id for truncate table

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Apr 12, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Merging #52591 (cbeac73) into master (1997ff7) will increase coverage by 2.1579%.
Report is 18 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52591        +/-   ##
================================================
+ Coverage   72.2344%   74.3923%   +2.1578%     
================================================
  Files          1469       1470         +1     
  Lines        427098     432387      +5289     
================================================
+ Hits         308512     321663     +13151     
+ Misses        99447      90754      -8693     
- Partials      19139      19970       +831     
Flag Coverage Δ
integration 48.8802% <100.0000%> (?)
unit 71.1813% <100.0000%> (+0.0566%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 49.7493% <ø> (+8.6593%) ⬆️

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 15, 2024
Copy link

ti-chi-bot bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 15, 2024
Copy link

ti-chi-bot bot commented Apr 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-12 11:37:34.649331484 +0000 UTC m=+1221516.176872028: ☑️ agreed by zimulala.
  • 2024-04-15 06:22:16.254579158 +0000 UTC m=+232755.365625607: ☑️ agreed by Benjamin2037.

@hawkingrei
Copy link
Member

/retest

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Merging #52591 (cbeac73) into master (1997ff7) will increase coverage by 1.5759%.
Report is 42 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52591        +/-   ##
================================================
+ Coverage   72.2344%   73.8104%   +1.5759%     
================================================
  Files          1469       1473         +4     
  Lines        427098     441355     +14257     
================================================
+ Hits         308512     325766     +17254     
+ Misses        99447      95511      -3936     
- Partials      19139      20078       +939     
Flag Coverage Δ
integration 48.9119% <100.0000%> (?)
unit 71.1813% <100.0000%> (+0.0566%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 49.7493% <ø> (+8.6593%) ⬆️

@wjhuang2016
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit ba0ebc5 into pingcap:master Apr 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check schema in job2UniqueIDs for TruncateTable
4 participants