-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoid_service: fix potential autoid decrease when leader change or close for AUTO_ID_CACHE=1 #52602
Conversation
…lose for AUTO_ID_CACHE=1
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52602 +/- ##
================================================
+ Coverage 70.7612% 73.4289% +2.6677%
================================================
Files 1470 1470
Lines 408762 435523 +26761
================================================
+ Hits 289245 319800 +30555
+ Misses 100213 95527 -4686
- Partials 19304 20196 +892
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PTAL @Defined2014 |
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, jackysp, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…lose for AUTO_ID_CACHE=1 (pingcap#52602) close pingcap#52600
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #52600
Problem Summary:
What changed and how does it work?
Check List
Tests
See the steps in #52600
I'll file another PR to support http API, because it import new changes rather than simple bug fix.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.