-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix 'Duplicate entry' error when @@auto_increment_increment and @@auto_increment_offset is set #52626
Conversation
Skipping CI for Draft Pull Request. |
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tangenta please also keep an eye on this. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52626 +/- ##
================================================
+ Coverage 72.3590% 75.1777% +2.8187%
================================================
Files 1470 1474 +4
Lines 427105 428189 +1084
================================================
+ Hits 309049 321903 +12854
+ Misses 98798 86010 -12788
- Partials 19258 20276 +1018
Flags with carried forward coverage won't be shown. Click here to find out more.
|
MySQL's document and implementation mismatch and it's a bug. We follow the MySQL document's. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, Defined2014, GMHDBJD The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Why not backport this PR to the LTS branches? |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #52622
Problem Summary:
What changed and how does it work?
Check List
Tests
Follow the steps in the issue
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.