-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: remove the retry for analyze (#52634) #52662
executor: remove the retry for analyze (#52634) #52662
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #52662 +/- ##
================================================
Coverage ? 72.3035%
================================================
Files ? 1468
Lines ? 426917
Branches ? 0
================================================
Hits ? 308676
Misses ? 98969
Partials ? 19272
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsa0520, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #52634
What problem does this PR solve?
Issue Number: close #52601
Problem Summary:
What changed and how does it work?
1、In v7.5, we have optimized the memory usage for analyze. so it is hard to OOM now.
2、If OOM happens, we should tell users about the oom event. we should not change the sample rate of the table.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.