-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: handle the case the type of param is set for the param sent by SEND_LONG_DATA
#52720
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #52720 +/- ##
================================================
+ Coverage 72.3357% 74.6173% +2.2816%
================================================
Files 1471 1481 +10
Lines 427132 437590 +10458
================================================
+ Hits 308969 326518 +17549
+ Misses 98881 91036 -7845
- Partials 19282 20036 +754
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/hold Need more tests |
/unhold |
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #52711
After sending the param through
SEND_LONG_DATA
, it's still possible that the type is given in theEXECUTE
statement. But actually I'm not sure whether every client sends the type, so I kept the original behavior if the type is not sent to keep compatibility.What changed and how does it work?
Assert whether the type is sent in
EXECUTE
statement. If it's sent, use the giventype. If it's not sent, still use the
Blob` to keep compatible with the original behavior.Check List
Tests
I tried to run the program https://gist.github.com/YangKeao/51bbc88600c69691a799227806f32cd5 on TiDB.
Before this PR, the data in table t after running this program is
After this PR, the data in table t after running this program is
Running this program in MySQL, will get:
Which is the same as what we got with this PR.
I'll try to add this manual test to
mysqlclienttest
later 🤔 .Release note