Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: add integration test for ingest corner case test (#52734) #52766

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52734

What problem does this PR solve?

Issue Number: close #52733

Problem Summary:
When creating index, log backup should be able to start.

What changed and how does it work?

remove the check, and add integration test.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 19, 2024
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-7.5@b5825e7). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #52766   +/-   ##
================================================
  Coverage               ?   71.9972%           
================================================
  Files                  ?       1411           
  Lines                  ?     410588           
  Branches               ?          0           
================================================
  Hits                   ?     295612           
  Misses                 ?      95122           
  Partials               ?      19854           
Flag Coverage Δ
unit 71.9972% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3144% <0.0000%> (?)

br/tests/README.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 25, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 6, 2024
@kennytm
Copy link
Contributor

kennytm commented May 9, 2024

PTAL @Benjamin2037 or @BornChanger

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor

Leavrth commented May 21, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented May 21, 2024

@Leavrth: No presubmit jobs available for pingcap/tidb@release-7.5

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Leavrth
Copy link
Contributor

Leavrth commented May 22, 2024

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 22, 2024
Copy link

ti-chi-bot bot commented May 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-25 00:48:57.421215774 +0000 UTC m=+221294.161118686: ☑️ agreed by lance6716.
  • 2024-05-22 02:59:04.398915381 +0000 UTC m=+2226898.156050954: ☑️ agreed by 3pointer.

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Benjamin2037, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit 51d5678 into pingcap:release-7.5 May 22, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants