Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: add integration test for ingest corner case test (#52734) #52767

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52734

What problem does this PR solve?

Issue Number: close #52733

Problem Summary:
When creating index, log backup should be able to start.

What changed and how does it work?

remove the check, and add integration test.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-8.1@2240762). Click here to learn what that means.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #52767   +/-   ##
================================================
  Coverage               ?   72.3530%           
================================================
  Files                  ?       1468           
  Lines                  ?     427346           
  Branches               ?          0           
================================================
  Hits                   ?     309198           
  Misses                 ?      98904           
  Partials               ?      19244           
Flag Coverage Δ
unit 71.2367% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.1118% <0.0000%> (?)

@Leavrth
Copy link
Contributor

Leavrth commented Apr 23, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Apr 23, 2024

@Leavrth: No presubmit jobs available for pingcap/tidb@release-8.1

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor

Leavrth commented Apr 23, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Apr 23, 2024

@Leavrth: No presubmit jobs available for pingcap/tidb@release-8.1

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 23, 2024
@Leavrth
Copy link
Contributor

Leavrth commented Apr 23, 2024

/retest

Copy link

ti-chi-bot bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 23, 2024
Copy link

ti-chi-bot bot commented Apr 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-23 06:53:29.277658518 +0000 UTC m=+70366.017561429: ☑️ agreed by Benjamin2037.
  • 2024-04-23 08:52:28.821445484 +0000 UTC m=+77505.561348418: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 23, 2024
@Leavrth
Copy link
Contributor

Leavrth commented Apr 24, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 4546180 into pingcap:release-8.1 Apr 24, 2024
31 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants