-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cop: ignore locks with the same start_ts (#52461) #52832
cop: ignore locks with the same start_ts (#52461) #52832
Conversation
Signed-off-by: ekexium <eke@fastmail.com>
Signed-off-by: ekexium <eke@fastmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #52832 +/- ##
================================================
Coverage ? 72.2701%
================================================
Files ? 1468
Lines ? 426934
Branches ? 0
================================================
Hits ? 308546
Misses ? 99095
Partials ? 19293
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/merge |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, you06 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cfzjywxk: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #52461
What problem does this PR solve?
Issue Number: close #52460
Problem Summary:
What changed and how does it work?
If this cop is not a stale read, which means its start_ts is fetched from PD, which means the start_ts cannot conflict with other transactions, add this ts to resolved_locks so that in a pipelined txn the locks belonging to the same txn will not block coprocessor.
For get and batch_get, they already put start_ts in resolved_locks.
Check List
Tests
insert into t select * from t
no longer reportsresolve lock timeout
error. I found it hard to be tested in unit test.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.