-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: fix flaky test TestStoreRemoved
#52834
br: fix flaky test TestStoreRemoved
#52834
Conversation
Signed-off-by: hillium <yu745514916@live.com>
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: hillium <yu745514916@live.com>
eed772e
to
36e67e9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52834 +/- ##
================================================
+ Coverage 72.3680% 75.4223% +3.0542%
================================================
Files 1474 1478 +4
Lines 427589 430716 +3127
================================================
+ Hits 309438 324856 +15418
+ Misses 98921 85640 -13281
- Partials 19230 20220 +990
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@YuJuncen: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: hillium <yu745514916@live.com>
/run-cherry-picker |
/run-cherry-picker |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: failed to apply #52834 on top of branch "release-8.1":
|
/run-cherry-picker |
close pingcap#52791, close pingcap#52792 Signed-off-by: hillium <yujuncen@pingcap.com>
close pingcap#52791, close pingcap#52792 Signed-off-by: hillium <yujuncen@pingcap.com>
/cherry-pick release-8.1 |
@wuhuizuo: failed to apply #52834 on top of branch "release-8.1":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #52791, close #52792
Problem Summary:
When dropping a subscription manager, the pending events will be dropped. So the test case will fail.
What changed and how does it work?
Wait until it seems there isn't new events.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.