Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: check local file existence before resume checkpoint (#53072) #53083

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53072

What problem does this PR solve?

Issue Number: close #53009

Problem Summary:

What changed and how does it work?

  • use word "flushed"/"imported" to replace "local"/"global" to unify the terminology with lightning engine
  • rename some methods
  • remove FlushModeForceLocalAndCheckDiskQuota because it's not used
  • use ctx to detect the closing of CheckpointManager and let other goroutine communications check the context
  • add a tagged logger to CheckpointManager
  • remove updating field because only one goroutine calls updateCheckpoint

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels May 7, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 21 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-8.1@238f2e6). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #53083   +/-   ##
================================================
  Coverage               ?   71.1352%           
================================================
  Files                  ?       1463           
  Lines                  ?     420659           
  Branches               ?          0           
================================================
  Hits                   ?     299237           
  Misses                 ?     100952           
  Partials               ?      20470           
Flag Coverage Δ
unit 71.1352% <85.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9651% <0.0000%> (?)

@lance6716
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 9, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 9, 2024
Copy link

ti-chi-bot bot commented May 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-07 10:52:13.437314214 +0000 UTC m=+959287.194449779: ☑️ agreed by lance6716.
  • 2024-05-09 02:02:15.499283682 +0000 UTC m=+1100289.256419284: ☑️ agreed by Benjamin2037.

@ti-chi-bot ti-chi-bot bot merged commit a4ab733 into pingcap:release-8.1 May 9, 2024
17 of 18 checks passed
Copy link

ti-chi-bot bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants