-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: check local file existence before resume checkpoint (#53072) #53083
ddl: check local file existence before resume checkpoint (#53072) #53083
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #53083 +/- ##
================================================
Coverage ? 71.1352%
================================================
Files ? 1463
Lines ? 420659
Branches ? 0
================================================
Hits ? 299237
Misses ? 100952
Partials ? 20470
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, lance6716, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #53072
What problem does this PR solve?
Issue Number: close #53009
Problem Summary:
What changed and how does it work?
FlushModeForceLocalAndCheckDiskQuota
because it's not usedctx
to detect the closing ofCheckpointManager
and let other goroutine communications check the contextCheckpointManager
updating
field because only one goroutine callsupdateCheckpoint
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.