Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix the collation of functions with json arguments (#53126) #53199

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53126

What problem does this PR solve?

Issue Number: close #52833

Problem Summary:

MySQL will use binary collation when the max_length of some arguments' types are too long. It'll mostly happen on JSON types.

What changed and how does it work?

As TiDB doesn't have a max_length attribute for each type and "datum", I specially handled the situation for JSON. Some function will return binary collation when some of the arguments are JSON type.

In MySQL, the state of BINARY flag, BLOB type and binary collation is really a chaos. For this example, you'll find that sometimes the collation(...) returns utf8mb4_bin while the returned type info (shown through --column-type-info) tells you the collation is utf8mb4_0900_ai_ci. I'm not sure whether it's a bug for MySQL or not...

So, I want to fix the behavior with minimum modification: only change the collation to binary collation and don't touch the charset.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that the collation of the result of some functions are not compatible with MySQL when the arguments contain JSON.

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot added compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels May 11, 2024
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-8.1@870c1fd). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #53199   +/-   ##
================================================
  Coverage               ?   71.2467%           
================================================
  Files                  ?       1465           
  Lines                  ?     421799           
  Branches               ?          0           
================================================
  Hits                   ?     300518           
  Misses                 ?     100823           
  Partials               ?      20458           
Flag Coverage Δ
unit 71.2467% <92.3076%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9907% <0.0000%> (?)

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 13, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 13, 2024
Copy link

ti-chi-bot bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XuHuaiyu, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 13, 2024
Copy link

ti-chi-bot bot commented May 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-13 06:04:59.624613157 +0000 UTC m=+1460453.381748732: ☑️ agreed by XuHuaiyu.
  • 2024-05-13 06:25:23.778547962 +0000 UTC m=+1461677.535683530: ☑️ agreed by YangKeao.

@YangKeao
Copy link
Member

/retest

1 similar comment
@YangKeao
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 52a9271 into pingcap:release-8.1 May 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants