-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix charset conversion warning and error behavior (#51191) #53227
expression: fix charset conversion warning and error behavior (#51191) #53227
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #53227 +/- ##
================================================
Coverage ? 71.1536%
================================================
Files ? 1465
Lines ? 421218
Branches ? 0
================================================
Hits ? 299712
Misses ? 101022
Partials ? 20484
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, YangKeao, zanmato1984 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…51191-to-release-8.1
This is an automated cherry-pick of #51191
What problem does this PR solve?
Issue Number: close #50295
Problem Summary:
The error
cannotConvertString
should have three different behaviors:cast
, and SQL_MODE is strict: it'll return NULL and add a warning.cast
, and SQL_MODE is not strict: it'll return truncated string and add a warning.cast
: it'll return an error.TiDB returns error in all cases, so it's not compatible.
What changed and how does it work?
Fix the behavior of
from_binary
function. Now it's only fixed on TiDB, and will need some modification on TiKV as well.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.