-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: add projections to keep join keys as col=col
(#52989)
#53326
planner: add projections to keep join keys as col=col
(#52989)
#53326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsa0520, hawkingrei, qw4990, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #53326 +/- ##
================================================
Coverage ? 71.1706%
================================================
Files ? 1465
Lines ? 421390
Branches ? 0
================================================
Hits ? 299906
Misses ? 101004
Partials ? 20480
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automated cherry-pick of #52989
What problem does this PR solve?
Issue Number: close #46556
Problem Summary: planner: add projections to keep join keys as
col=col
What changed and how does it work?
In some cases, after creating new EQ function, the 2 args might not be column anymore, which breaks the assumption that join eq keys must be
col=col
, to handle this, inject 2 projections.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.