-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: set max token limit to 1M #53361
Conversation
Hi @djshow832. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53361 +/- ##
================================================
+ Coverage 72.5147% 73.7039% +1.1892%
================================================
Files 1498 1523 +25
Lines 429925 436146 +6221
================================================
+ Hits 311759 321457 +9698
+ Misses 98883 94778 -4105
- Partials 19283 19911 +628
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[LGTM Timeline notifier]Timeline:
|
/retest |
@djshow832: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, easonn7, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #53312
Problem Summary:
If a user sets
token-limit
to a big value, TiDB will OOM.What changed and how does it work?
If the token-limit is bigger than 1M, set it to 1M.
It won't report errors so it's compatible with previous versions.
One TiDB instance won't have over 1M concurrent queries because that will mean at least 1M goroutines and file descriptors.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.