Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: set max token limit to 1M #53361

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

djshow832
Copy link
Contributor

@djshow832 djshow832 commented May 17, 2024

What problem does this PR solve?

Issue Number: close #53312

Problem Summary:
If a user sets token-limit to a big value, TiDB will OOM.

What changed and how does it work?

If the token-limit is bigger than 1M, set it to 1M.
It won't report errors so it's compatible with previous versions.
One TiDB instance won't have over 1M concurrent queries because that will mean at least 1M goroutines and file descriptors.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

- Lower the max value of `token-limit` to 1048576 to avoid OOM

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2024
Copy link

tiprow bot commented May 17, 2024

Hi @djshow832. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.7039%. Comparing base (491740b) to head (7de9cfa).
Report is 8 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53361        +/-   ##
================================================
+ Coverage   72.5147%   73.7039%   +1.1892%     
================================================
  Files          1498       1523        +25     
  Lines        429925     436146      +6221     
================================================
+ Hits         311759     321457      +9698     
+ Misses        98883      94778      -4105     
- Partials      19283      19911       +628     
Flag Coverage Δ
integration 49.2172% <0.0000%> (?)
unit 71.3547% <100.0000%> (-0.0563%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 42.5655% <ø> (+0.9645%) ⬆️

@djshow832 djshow832 requested review from Defined2014 and xhebox May 17, 2024 08:55
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 17, 2024
@djshow832 djshow832 removed the request for review from xhebox May 17, 2024 09:03
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 17, 2024
Copy link

ti-chi-bot bot commented May 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-17 08:59:56.383601141 +0000 UTC m=+1816550.140736710: ☑️ agreed by Defined2014.
  • 2024-05-17 10:54:32.89082933 +0000 UTC m=+1823426.647965070: ☑️ agreed by xhebox.

@djshow832
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented May 17, 2024

@djshow832: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@djshow832
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label May 17, 2024
@easonn7
Copy link

easonn7 commented May 17, 2024

/approve

Copy link

ti-chi-bot bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, easonn7, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 17, 2024
@ti-chi-bot ti-chi-bot bot merged commit 335af25 into pingcap:master May 17, 2024
23 checks passed
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
@djshow832 djshow832 deleted the token_limit branch May 18, 2024 02:24
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 22, 2024
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The max value of token-limit should be more reasonable
4 participants