expression: Disallow conv fuction with hybrid type argement to be pushed down to TiKV

[yibin87]

What problem does this PR solve?

Issue Number: close #51877

Problem Summary:

What changed and how does it work?

As described in #51877, such case can't be supported in TiKV side, just disallow it to be pushed down.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @yibin87. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yibin87]

/cc @windtalker @xzhangxian1008

[xzhangxian1008]

Maybe we can test pushdown with integration test like this

[yibin87]

Nice suggestion. For this case, the push down check is very simple and straightforward, I think the expr_to_pb_test can cover the functionality alread.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6281%. Comparing base (fe5858b) to head (b1f584b).
Report is 4 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #53502        +/-   ##
================================================
+ Coverage   72.5209%   74.6281%   +2.1072%     
================================================
  Files          1505       1505                
  Lines        429883     430516       +633     
================================================
+ Hits         311755     321286      +9531     
+ Misses        98840      89334      -9506     
- Partials      19288      19896       +608     

Flag	Coverage Δ
integration	49.4347% <12.5000%> (?)
unit	71.3285% <100.0000%> (-0.0794%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	50.4198% <ø> (+9.0157%)	⬆️

[yibin87]

/test check-dev2

[tiprow]

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yibin87]

/test unit-test

[tiprow]

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yibin87]

/test check-dev2

[tiprow]

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yibin87]

/test unit-test

[tiprow]

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[windtalker]

Don't need to check IsBinaryLiteral(f.GetArgs()[0]) here?

[yibin87]

Not quite sure if constant folding may not take effect. Added for safety.

[yibin87]

/test unit-test

[tiprow]

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[windtalker]

LGTM

[xzhangxian1008]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/expression/OWNERS [windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-05-23 07:14:18.237739811 +0000 UTC m=+2328611.994875384: ☑️ agreed by windtalker.
• 2024-05-23 09:15:27.784212934 +0000 UTC m=+2335881.541348509: ☑️ agreed by xzhangxian1008.

[tiprow]

@yibin87: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	b1f584b	link	true	/test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.