Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test TestSyncJobSchemaVerLoop #53507

Merged
merged 1 commit into from
May 23, 2024

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented May 23, 2024

What problem does this PR solve?

Issue Number: close #53508

Problem Summary:

What changed and how does it work?

the require.Zero(t, jobNodeVersionCnt()) check might fail if the loop cancelled before it receive the last DELETE event. it does not affect the correctness, so remove it.
see https://tiprow.hawkingrei.com/view/gs/pingcapprow/pr-logs/pull/pingcap_tidb/53489/fast_test_tiprow/1793524686622035968

    syncer_nokit_test.go:192: 
        	Error Trace:	pkg/ddl/syncer/syncer_nokit_test.go:192
        	Error:      	Should be zero, but was 1
        	Test:       	TestSyncJobSchemaVerLoop

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2024
@D3Hunter D3Hunter added skip-issue-check Indicates that a PR no need to check linked issue. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2024
Copy link

tiprow bot commented May 23, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 23, 2024
Copy link

ti-chi-bot bot commented May 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-23 07:03:46.70581632 +0000 UTC m=+2327980.462951885: ☑️ agreed by lance6716.
  • 2024-05-23 07:11:52.975557088 +0000 UTC m=+2328466.732692662: ☑️ agreed by hawkingrei.

@hawkingrei hawkingrei removed the skip-issue-check Indicates that a PR no need to check linked issue. label May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.5038%. Comparing base (22dc064) to head (8e9b526).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53507        +/-   ##
================================================
+ Coverage   74.4026%   74.5038%   +0.1012%     
================================================
  Files          1505       1505                
  Lines        357263     430473     +73210     
================================================
+ Hits         265813     320719     +54906     
- Misses        72137      89845     +17708     
- Partials      19313      19909       +596     
Flag Coverage Δ
integration 49.1313% <0.0000%> (?)
unit 71.3299% <0.0000%> (-1.9427%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 50.3892% <ø> (+7.3076%) ⬆️

Copy link

ti-chi-bot bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 23, 2024
@ti-chi-bot ti-chi-bot bot merged commit 322f87a into pingcap:master May 23, 2024
23 checks passed
@D3Hunter D3Hunter deleted the fix-flaky-check branch May 23, 2024 08:15
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestSyncJobSchemaVerLoop
4 participants