-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix privilege for the view in the CTE and wrong error handle (#53556) #53628
planner: fix privilege for the view in the CTE and wrong error handle (#53556) #53628
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
/retest |
1 similar comment
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #53628 +/- ##
================================================
Coverage ? 72.0411%
================================================
Files ? 1411
Lines ? 410635
Branches ? 0
================================================
Hits ? 295826
Misses ? 94929
Partials ? 19880
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
3 similar comments
/retest |
/retest |
/retest |
This is an automated cherry-pick of #53556
What problem does this PR solve?
Issue Number: close #49721
Problem Summary:
What changed and how does it work?
1、error handle is wrong. Any error will return
PrivilegeErro
2、
RequestVerificationWithUser
meet empty user, it should return true.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.