Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Add a GetDBMeta function to meta. #53684

Merged
merged 8 commits into from
Jun 4, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions pkg/meta/meta.go
Original file line number Diff line number Diff line change
Expand Up @@ -1022,6 +1022,51 @@ func (m *Meta) ListTables(dbID int64) ([]*model.TableInfo, error) {
return tables, nil
}

// ListTablesByFilter return all tables that does not filtered by filter in a database.
asddongmen marked this conversation as resolved.
Show resolved Hide resolved
// Note(dongmen): This method is used by TiCDC to reduce the time of changefeed initialization.
// Ref: https://github.com/pingcap/tiflow/issues/11109
func (m *Meta) ListTablesByFilter(
asddongmen marked this conversation as resolved.
Show resolved Hide resolved
dbID int64,
filter func(info *model.TableNameInfo) bool) ([]*model.TableInfo, error) {
dbKey := m.dbKey(dbID)
if err := m.checkDBExists(dbKey); err != nil {
return nil, errors.Trace(err)
}

res, err := m.txn.HGetAll(dbKey)
if err != nil {
return nil, errors.Trace(err)
}

tables := make([]*model.TableInfo, 0, len(res)/2)
for _, r := range res {
// only handle table meta
tableKey := string(r.Field)
if !strings.HasPrefix(tableKey, mTablePrefix) {
continue
}
tbName := &model.TableNameInfo{}
err = json.Unmarshal(r.Value, tbName)
if err != nil {
return nil, errors.Trace(err)
}
if filter(tbName) {
continue
}
asddongmen marked this conversation as resolved.
Show resolved Hide resolved

tbInfo := &model.TableInfo{}
err = json.Unmarshal(r.Value, tbInfo)
if err != nil {
return nil, errors.Trace(err)
}
tbInfo.DBID = dbID

tables = append(tables, tbInfo)
}

return tables, nil
}

// ListSimpleTables shows all simple tables in database.
func (m *Meta) ListSimpleTables(dbID int64) ([]*model.TableNameInfo, error) {
dbKey := m.dbKey(dbID)
Expand Down
10 changes: 10 additions & 0 deletions pkg/meta/meta_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,16 @@ func TestMeta(t *testing.T) {
})
require.NoError(t, err)
}

asddongmen marked this conversation as resolved.
Show resolved Hide resolved
// Test ListTableByFilter
filter := func(tableName *model.TableNameInfo) bool {
return tableName.Name != tblName.Name
}
filteredTables, err := m.ListTablesByFilter(1, filter)
require.NoError(t, err)
require.Len(t, filteredTables, 1)
require.Equal(t, tblName.Name, filteredTables[0].Name)

// Generate an auto id.
n, err = m.GetAutoIDAccessors(1, 2).RowID().Inc(10)
require.NoError(t, err)
Expand Down