ddl: get latest old table ID before replace view

[tangenta]

What problem does this PR solve?

Issue Number: close #53673

Problem Summary:

When we specify OR REPLACE clause in CREATE VIEW statements, if there is an old view, it will be dropped first. However, this old view ID comes from DDL job arguments:

tidb/pkg/ddl/table.go

Line 311 in 35e09a2

var oldTbInfoID int64

If there are many concurrent CREATE VIEW DDL jobs summiting to the queue, the old view ID maybe outdated. Then we will encounter 'table doesn't exist' error:

tidb/pkg/ddl/table.go

Lines 341 to 344 in 35e09a2

	err = t.DropTableOrView(schemaID, job.SchemaName, oldTbInfoID, tbInfo.Name.L)
	if err != nil {
	job.State = model.JobStateCancelled
	return ver, errors.Trace(err)

What changed and how does it work?

Discard the old view ID from DDL job arguments. Always get the latest old view ID.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
  Run the script mentioned in issue, and

  mysql> admin show ddl jobs;
  +--------+---------+------------+-------------+--------------+-----------+----------+-----------+----------------------------+----------------------------+----------------------------+--------+
  | JOB_ID | DB_NAME | TABLE_NAME | JOB_TYPE    | SCHEMA_STATE | SCHEMA_ID | TABLE_ID | ROW_COUNT | CREATE_TIME                | START_TIME                 | END_TIME                   | STATE  |
  +--------+---------+------------+-------------+--------------+-----------+----------+-----------+----------------------------+----------------------------+----------------------------+--------+
  |    539 | test    | v          | create view | public       |         2 |      538 |         0 | 2024-05-31 17:10:03.734000 | 2024-05-31 17:10:03.784000 | 2024-05-31 17:10:03.835000 | synced |
  |    537 | test    | v          | create view | public       |         2 |      536 |         0 | 2024-05-31 17:10:03.634000 | 2024-05-31 17:10:03.634000 | 2024-05-31 17:10:03.685000 | synced |
  |    535 | test    | v          | create view | public       |         2 |      534 |         0 | 2024-05-31 17:10:03.485000 | 2024-05-31 17:10:03.535000 | 2024-05-31 17:10:03.585000 | synced |
  

• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 72.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 74.8354%. Comparing base (b137425) to head (efe6b93).
Report is 14 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #53720        +/-   ##
================================================
+ Coverage   72.5762%   74.8354%   +2.2591%     
================================================
  Files          1506       1506                
  Lines        430947     435910      +4963     
================================================
+ Hits         312765     326215     +13450     
+ Misses        98878      89740      -9138     
- Partials      19304      19955       +651     

Flag	Coverage Δ
integration	49.4392% <68.0000%> (?)
unit	71.6576% <62.0000%> (+0.0868%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <ø> (-1.0302%)	⬇️
parser	∅ <ø> (∅)
br	50.3763% <ø> (+8.5419%)	⬆️

[lance6716]

rest lgtm

[lance6716]

rest lgtm

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/ddl/OWNERS [wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-06-03 07:34:34.694822188 +0000 UTC m=+3280228.451957756: ☑️ agreed by lance6716.
• 2024-06-03 09:01:22.028371379 +0000 UTC m=+3285435.785507080: ☑️ agreed by wjhuang2016.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #53774.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #54576.

[ti-chi-bot]

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-8.1 from head ti-chi-bot:cherry-pick-53720-to-release-8.1: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID 8AAC:12E1BA:5C4BAB:AF9800:66A35411 and timestamp 2024-07-26 07:45:21 UTC.","documentation_url":"https://docs.github.com/rest/overview/rate-limits-for-the-rest-api#about-secondary-rate-limits","status":"403"}

[lance6716]

/cherry-pick release-8.1

[ti-chi-bot]

@lance6716: new pull request created to branch release-8.1: #55095.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.