Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infoschema: fix the issue txn state size is not defined (#53801) #53826

Merged
merged 4 commits into from
Jun 11, 2024
Merged

infoschema: fix the issue txn state size is not defined (#53801) #53826

merged 4 commits into from
Jun 11, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53801

What problem does this PR solve?

Issue Number: close #53026

Problem Summary:
Fix the issue the size is not defined for tidb_trx table.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue the size is not defined for `tidb_trx` table.

@cfzjywxk @ti-chi-bot
This is an automated cherry-pick of pingcap#53801
b4d5004 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jun 5, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 5, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 5, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2024
ekexium
ekexium approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@ekexium ekexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a conflict

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 5, 2024
@cfzjywxk
resolve conflicts
2f36c08 
Signed-off-by: cfzjywxk <cfzjywxk@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 5, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 11, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-05 11:52:40.200526947 +0000 UTC m=+3468513.957662516: ☑️ agreed by ekexium.
  • 2024-06-11 02:26:16.738992406 +0000 UTC m=+431530.792304330: ☑️ agreed by zyguan.

@cfzjywxk
Copy link
Contributor

/test unit-test

@tiprow tiprow
Copy link

tiprow bot commented Jun 11, 2024

@cfzjywxk: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, ekexium, wjhuang2016, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [crazycs520,ekexium,wjhuang2016,zyguan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cfzjywxk
Copy link
Contributor

/retest

@cfzjywxk
fix test
25a7776 
Signed-off-by: cfzjywxk <cfzjywxk@gmail.com>
@cfzjywxk
stable test
7501098 
Signed-off-by: cfzjywxk <cfzjywxk@gmail.com>
@ti-chi-bot ti-chi-bot bot merged commit 60b127f into pingcap:release-6.5 Jun 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekexium ekexium ekexium approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@zyguan zyguan zyguan approved these changes

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

Assignees

@cfzjywxk cfzjywxk

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @cfzjywxk @zyguan @wjhuang2016 @crazycs520 @ekexium