planner: change the rewrite rule of row expression

[elsa0520]

What problem does this PR solve?

(x,y,z) op (a,b,c)
rewritten
(x op a) or (x = a and y op b) or (x = a and y = b and z op c)

The new rewriting method allows buildrange to handle range construction problems more conveniently.

Issue Number: close #41598

Problem Summary:

What changed and how does it work?

The old expression rewrite is rewritten row expression to if(x!=a, x> a, if(xxxx)). The range builder could not easy build and merge this kind of expr range.

The new expression rewritten to (x op a) or (x = a and y op b) or (x = a and y = b and z op c) . It will be rewritten as a DNF which is more conveniently for Range builder.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

The row expression will be rewritten into DNF. This form is more conducive to more precise range builder of the index, thereby reducing key reading.

[tiprow]

Hi @elsa0520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[elsa0520]

Testing, not ready to merge

[codecov]

Codecov Report

Attention: Patch coverage is 83.78378% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.6515%. Comparing base (b96a775) to head (2db6374).
Report is 41 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #53928         +/-   ##
=================================================
- Coverage   72.5347%   56.6515%   -15.8833%     
=================================================
  Files          1508       1640        +132     
  Lines        432015     618280     +186265     
=================================================
+ Hits         313361     350265      +36904     
- Misses        99268     244593     +145325     
- Partials      19386      23422       +4036     

Flag	Coverage Δ
integration	37.2764% <83.7837%> (?)
unit	71.7730% <83.7837%> (+0.2454%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <ø> (+0.0188%)	⬆️
parser	∅ <ø> (∅)
br	52.3531% <ø> (+10.0903%)	⬆️

[fixdb]

Are you going to add test cases?

[elsa0520]

Are you going to add test cases?

Yes, I haven't finish the test.

[ti-chi-bot]

@ghazalfamilyusa: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[time-and-fate]

Others LGTM.

[time-and-fate]

I think the comments here are a little confusing, especially the "should be converted to".
Actually, we are not "convert"ing it to the AND list. We are just preparing the prefix columns part of the final result.
And also at this stage, we haven't connected them using AND yet.

[elsa0520]

Changed

[ti-chi-bot]

@ghazalfamilyusa: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hawkingrei]

/ok-to-test

[elsa0520]

/test unit-test

[tiprow]

@elsa0520: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[elsa0520]

/test unit-test

[tiprow]

@elsa0520: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-06-18 04:22:01.870776656 +0000 UTC m=+88648.356265487: ☑️ agreed by time-and-fate.
• 2024-06-20 10:02:02.900302194 +0000 UTC m=+281849.385791028: ☑️ agreed by AilinKid.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, ghazalfamilyusa, hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/planner/OWNERS [AilinKid,hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment