Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: update some vars for internal sessions correctly (#53977) #53988

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53977

What problem does this PR solve?

Issue Number: close #53972

Problem Summary:

What changed and how does it work?

We need to always update these vars for internal sessions. Otherwise, it won't work. And we will use the wrong default value.

See more at the issue.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

修复 tidb_enable_async_merge_global_stats 和 tidb_analyze_partition_concurrency 在自动分析无法生效的问题
Fix tidb_enable_async_merge_global_stats and tidb_analyze_partition_concurrency not working in auto-analysis

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner labels Jun 13, 2024
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Jun 13, 2024
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 13, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 18, 2024
Copy link

ti-chi-bot bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 18, 2024
@Rustin170506
Copy link
Member

/retest

Copy link

ti-chi-bot bot commented Jun 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-13 07:51:30.600730968 +0000 UTC m=+623844.654042884: ☑️ agreed by fixdb.
  • 2024-06-18 09:12:51.348447094 +0000 UTC m=+106097.833935926: ☑️ agreed by hi-rustin.

@Rustin170506
Copy link
Member

/retest

@Rustin170506
Copy link
Member

/retest

1 similar comment
@Rustin170506
Copy link
Member

/retest

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@3c02c2a). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #53988   +/-   ##
================================================
  Coverage               ?   72.1459%           
================================================
  Files                  ?       1411           
  Lines                  ?     411596           
  Branches               ?          0           
================================================
  Hits                   ?     296950           
  Misses                 ?      94822           
  Partials               ?      19824           
Flag Coverage Δ
unit 72.1459% <50.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4897% <0.0000%> (?)

@Rustin170506
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 497f837 into pingcap:release-7.5 Jul 3, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants