backup: add version checker for store based backup #54131
Conversation
ti-chi-bot
bot
added
release-note-none
|
Hi @3pointer. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| // 8.2 br(store based backup) does not support tikv <= 8.1 | ||
| // due to the performance issue https://github.com/tikv/tikv/issues/17168 | ||
| // TODO: we can remove this check if the performance issue is fixed and cherry-pick | ||
| if (BRVersion.Major > 8 || (BRVersion.Major == 8 && BRVersion.Minor >= 2)) && |
There was a problem hiding this comment.
This check is always true?
There was a problem hiding this comment.
If this PR wasn't cherry-picked, it looks always true. But I guess this won't be really harmful.
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54131 +/- ##
=================================================
- Coverage 74.9170% 56.6143% -18.3027%
=================================================
Files 1516 1639 +123
Lines 360903 606860 +245957
=================================================
+ Hits 270378 343570 +73192
- Misses 71031 239672 +168641
- Partials 19494 23618 +4124
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| // 8.2 br(store based backup) does not support tikv <= 8.1 | ||
| // due to the performance issue https://github.com/tikv/tikv/issues/17168 | ||
| // TODO: we can remove this check if the performance issue is fixed and cherry-pick | ||
| if (BRVersion.Major > 8 || (BRVersion.Major == 8 && BRVersion.Minor >= 2)) && |
There was a problem hiding this comment.
If this PR wasn't cherry-picked, it looks always true. But I guess this won't be really harmful.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leavrth, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/retest |
|
@3pointer: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@3pointer: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ti-chi-bot
added
the
needs-cherry-pick-release-7.5
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
added
the
needs-cherry-pick-release-6.5
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
added
the
needs-cherry-pick-release-8.1
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #52534
Problem Summary:
Due to tikv/tikv#17168, the current tikv does not support backup with subranges very well.
So we need a version checker in case of use store based backup running on old version of tikv.(There is no correctness issue, but the performance may not work as expected.)
What changed and how does it work?
Add a version check
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.