Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update tikv/client-go #54229

Closed

Conversation

crazycs520
Copy link
Contributor

cherry-pick #54227

What problem does this PR solve?

Issue Number: close #54226

Problem Summary: related PR: tikv/client-go#1374

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed do-not-merge/invalid-title do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 26, 2024
Copy link

ti-chi-bot bot commented Jun 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 26, 2024
@crazycs520 crazycs520 changed the title Update client go 1374 8.2 *: update tikv/client-go Jun 26, 2024
@crazycs520 crazycs520 marked this pull request as ready for review June 26, 2024 07:12
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2024
Copy link

tiprow bot commented Jun 26, 2024

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@crazycs520 crazycs520 changed the base branch from master to release-8.2 June 26, 2024 07:13
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.5245%. Comparing base (b3ed886) to head (ab2a917).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           release-8.2     #54229         +/-   ##
====================================================
- Coverage      72.8667%   56.5245%   -16.3422%     
====================================================
  Files             1519       1643        +124     
  Lines           435373     611492     +176119     
====================================================
+ Hits            317242     345643      +28401     
- Misses           98583     242704     +144121     
- Partials         19548      23145       +3597     
Flag Coverage Δ
integration 37.8614% <ø> (?)
unit 72.3922% <ø> (+0.5165%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.7691% <ø> (+6.6206%) ⬆️

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 26, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 26, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 26, 2024
Copy link

ti-chi-bot bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, MyonKeminta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MyonKeminta,cfzjywxk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 26, 2024
Copy link

ti-chi-bot bot commented Jun 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-26 07:55:25.187448504 +0000 UTC m=+792651.672937336: ☑️ agreed by cfzjywxk.
  • 2024-06-26 08:34:18.973380442 +0000 UTC m=+794985.458869272: ☑️ agreed by MyonKeminta.

@crazycs520
Copy link
Contributor Author

/retest-required

Copy link

tiprow bot commented Jun 26, 2024

@crazycs520: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@crazycs520
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jun 26, 2024
@crazycs520
Copy link
Contributor Author

/run-check-issue-triage-complete

1 similar comment
@crazycs520
Copy link
Contributor Author

/run-check-issue-triage-complete

@crazycs520
Copy link
Contributor Author

/retest-required

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520 crazycs520 closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/needs-triage-completed lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecated config enable-replica-selector-v2
4 participants