Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, executor: fix index lookup join's inner index order should should be correctly mapped to join keys #54249

Closed
wants to merge 2 commits into from

Conversation

AilinKid
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #54064

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner, executor: fix index lookup join's inner index order should should be correctly mapped to join keys

…mapped to join keys

Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed sig/planner SIG: Planner labels Jun 26, 2024
Copy link

ti-chi-bot bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ailinkid, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 26, 2024
Copy link

tiprow bot commented Jun 26, 2024

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

// eg: join(b,a), idx1(a,b,c)
// since we need to keep the join keys order, so we need to reorder the outers keys offset to make it
// if outer keys don't follow the inner index's order.
orderByIdxOffset2KeyOff[idxOff] = idxOff2KeyOffMap[idxOff]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the main change is here

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.0804%. Comparing base (432bb79) to head (dec9200).
Report is 129 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54249         +/-   ##
=================================================
- Coverage   72.9282%   56.0804%   -16.8478%     
=================================================
  Files          1523       1638        +115     
  Lines        435564     605535     +169971     
=================================================
+ Hits         317649     339587      +21938     
- Misses        98420     242564     +144144     
- Partials      19495      23384       +3889     
Flag Coverage Δ
integration 22.3308% <60.0000%> (?)
unit 71.8146% <96.6666%> (-0.1290%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.6985% <ø> (+6.5299%) ⬆️

.
Signed-off-by: AilinKid <314806019@qq.com>
Copy link

ti-chi-bot bot commented Jun 27, 2024

@AilinKid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev dec9200 link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 dec9200 link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@AilinKid
Copy link
Contributor Author

after we discussion with the execution team, we are going to deprecate the index_merge_join hint.

@AilinKid AilinKid closed this Jul 17, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexMergeJoin get different result when using different charset
2 participants