-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix empty SQL in slow log for internal statement #54274
Conversation
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/check-issue-triage-complete |
/check-issue-triage-complete |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54274 +/- ##
=================================================
- Coverage 74.7837% 56.3466% -18.4372%
=================================================
Files 1523 1644 +121
Lines 361533 614159 +252626
=================================================
+ Hits 270368 346058 +75690
- Misses 71520 244775 +173255
- Partials 19645 23326 +3681
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: easonn7, xhebox, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #54190 , close #52743 , close #53264
What changed and how does it work?
The internal session does not init
EnableRedactLog
which causeredact.String
always returns empty string.Init it as an default value in this PR.
Check List
Tests
And check the output slow logs. No empty strings again.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.