planner: fix index out of range in constructIndexJoinInnerSideTask

[joechenrh]

What problem does this PR solve?

Issue Number: close #54535

Problem Summary:

When set system variable tidb_enable_inl_join_inner_multi_pattern to ON, the following SQL will get an error.

set GLOBAL tidb_enable_inl_join_inner_multi_pattern='ON';
create table ta(a1 int, a2 int, a3 int, index idx_a(a1));
create table tb(b1 int, b2 int, b3 int, index idx_b(b1));
explain SELECT /*+ inl_join(tmp) */ * FROM ta, (SELECT b1, COUNT(b3) AS cnt FROM tb GROUP BY b1, b2) as tmp where ta.a1 = tmp.b1;

ERROR 1105 (HY000): runtime error: index out of range [1] with length 1

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

Welcome @joechenrh!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

[ti-chi-bot]

Hi @joechenrh. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[hawkingrei]

/ok-to-test

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.6463%. Comparing base (cf4bb51) to head (9e369c9).
Report is 59 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #54534        +/-   ##
================================================
- Coverage   74.7249%   74.6463%   -0.0786%     
================================================
  Files          1558       1575        +17     
  Lines        363817     455938     +92121     
================================================
+ Hits         271862     340341     +68479     
- Misses        72284      95041     +22757     
- Partials      19671      20556       +885     

Flag	Coverage Δ
integration	49.5084% <85.7142%> (?)
unit	71.6990% <16.6666%> (-1.9139%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <ø> (-2.2327%)	⬇️
parser	∅ <ø> (∅)
br	52.3065% <ø> (+4.5800%)	⬆️

[joechenrh]

/retest

[hawkingrei]

You can use tk.MustQuery("explain xxx") to check whether the planner is right.

[winoros]

Just align with other test case name

[winoros]

Suggested change

	func Test54535(t *testing.T) {
	func TestIssue54535(t *testing.T) {

[AilinKid]

/retest-required

[hawkingrei]

@joechenrh Please sync the code with master.

[joechenrh]

/retest-required

[lance6716]

/retest

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/planner/OWNERS [winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-08-01 02:30:27.562199475 +0000 UTC m=+409343.842247529: ☑️ agreed by lance6716.
• 2024-08-01 14:23:55.514924947 +0000 UTC m=+13032.733686566: ☑️ agreed by winoros.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #55145.