-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: refine the connection counter logic (#54546) #54611
Merged
ti-chi-bot
merged 2 commits into
pingcap:release-7.5
from
ti-chi-bot:cherry-pick-54546-to-release-7.5
Jul 16, 2024
Merged
server: refine the connection counter logic (#54546) #54611
ti-chi-bot
merged 2 commits into
pingcap:release-7.5
from
ti-chi-bot:cherry-pick-54546-to-release-7.5
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
5 tasks
ti-chi-bot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/cherry-pick-for-release-7.5
This PR is cherry-picked to release-7.5 from a source PR.
labels
Jul 15, 2024
ti-chi-bot
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Jul 16, 2024
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
xhebox
approved these changes
Jul 16, 2024
/retest |
1 similar comment
/retest |
/approve |
tiancaiamao
approved these changes
Jul 16, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: easonn7, tiancaiamao, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
labels
Jul 16, 2024
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/cherry-pick-for-release-7.5
This PR is cherry-picked to release-7.5 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #54546
What problem does this PR solve?
Issue Number: close #54545, close #54428
Problem Summary:
This PR solve two problems:
registerConn
, and decreases inconn.Close()
(if theconn.getCtx()
is not nil). If the connection exists before handshake successfully, for example authentication failed, the total connection count will decrease one 🤦.SET SESSION_STATES
(usually used bytiproxy
) didn't INC/DEC the connection count for the resource group if it's changed.What changed and how does it work?
This PR reorganized the codes INC/DEC the metric gauge in the following pattern:
newConn
with default resource group name, so that it can make sure the connection count will always increase.closeConn
. If the connection doesn't have a valid context, it'll decrease in the default resource group.Other use case of the
ConnGauge
always comes in pair: increase one and decrease another one. This PR provides a methodSetResourceGroupName
to change the session vars and always INC/DEC the metric counter. It'll be called inSET SESSION_STATES
,SET RESOURCE GROUP
and authentication (because the user may carry a resource group info).Check List
Tests
Release note