-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planer: fix invalid pointer caused by a recursive CTE query (#54450) #54677
planer: fix invalid pointer caused by a recursive CTE query (#54450) #54677
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #54677 +/- ##
================================================
Coverage ? 71.2865%
================================================
Files ? 1465
Lines ? 422279
Branches ? 0
================================================
Hits ? 301028
Misses ? 100787
Partials ? 20464
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #54450
What problem does this PR solve?
Issue Number: close #54449
Problem Summary:
What changed and how does it work?
in the
FindBestTask
, we should returnbase.InvalidTask
when it doesn't meet requirement. but now it returns nil. it is the root causion.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.