Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: Fix BatchPointGetPlan.HandleColOffset #54686

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Jul 17, 2024

What problem does this PR solve?

Issue Number: close #54667

Problem Summary:
Similar to #52198, but for BatchPointGet.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 17, 2024
@mjonss mjonss requested a review from Defined2014 July 17, 2024 09:36
Copy link

tiprow bot commented Jul 17, 2024

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mjonss mjonss requested a review from winoros July 17, 2024 09:37
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.2136%. Comparing base (ca7ba14) to head (37bbe08).
Report is 41 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54686         +/-   ##
=================================================
- Coverage   74.6668%   57.2136%   -17.4533%     
=================================================
  Files          1551       1681        +130     
  Lines        362786     621993     +259207     
=================================================
+ Hits         270881     355865      +84984     
- Misses        72307     242928     +170621     
- Partials      19598      23200       +3602     
Flag Coverage Δ
integration 38.3972% <100.0000%> (?)
unit 72.8129% <100.0000%> (-0.7805%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-2.2339%) ⬇️
parser ∅ <ø> (∅)
br 52.4708% <ø> (+4.8107%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 17, 2024
@Defined2014 Defined2014 requested a review from qw4990 July 18, 2024 05:12
Copy link

ti-chi-bot bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 22, 2024
Copy link

ti-chi-bot bot commented Jul 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-17 10:36:17.921467552 +0000 UTC m=+436599.912409024: ☑️ agreed by Defined2014.
  • 2024-07-22 07:19:18.525111622 +0000 UTC m=+856780.516053094: ☑️ agreed by hawkingrei.

@mjonss
Copy link
Contributor Author

mjonss commented Jul 22, 2024

/retest

Copy link

tiprow bot commented Jul 22, 2024

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 669bf4d into pingcap:master Jul 22, 2024
21 of 23 checks passed
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. and removed needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jul 30, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 30, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #55060.

@mjonss mjonss deleted the fix-54667 branch August 5, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-8.1 approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic during partition location for key and hash partition
4 participants