-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix query panic on INFORMATION_SCHEMA.CLUSTER_SLOW_QUERY with some slow query files (#54325) #54710
executor: fix query panic on INFORMATION_SCHEMA.CLUSTER_SLOW_QUERY with some slow query files (#54325) #54710
Conversation
…th some slow query files
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #54710 +/- ##
================================================
Coverage ? 72.3133%
================================================
Files ? 1465
Lines ? 432729
Branches ? 0
================================================
Hits ? 312921
Misses ? 99573
Partials ? 20235
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, Defined2014 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
This is an automated cherry-pick of #54325
What problem does this PR solve?
Issue Number: close #54324
Problem Summary:
What changed and how does it work?
The old code does not handle all the cases well.
if i >= len(lines)-1
should be a typo, it should be something likeif i >= len(chars)-1
And the simplified logic is just the same as this PR.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.