-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix query panic on INFORMATION_SCHEMA.CLUSTER_SLOW_QUERY with some slow query files (#54325) #54711
base: release-7.5
Are you sure you want to change the base?
executor: fix query panic on INFORMATION_SCHEMA.CLUSTER_SLOW_QUERY with some slow query files (#54325) #54711
Conversation
…th some slow query files
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #54711 +/- ##
================================================
Coverage ? 72.0181%
================================================
Files ? 1412
Lines ? 411353
Branches ? 0
================================================
Hits ? 296249
Misses ? 95218
Partials ? 19886
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automated cherry-pick of #54325
What problem does this PR solve?
Issue Number: close #54324
Problem Summary:
What changed and how does it work?
The old code does not handle all the cases well.
if i >= len(lines)-1
should be a typo, it should be something likeif i >= len(chars)-1
And the simplified logic is just the same as this PR.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.