-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: must set line terminator when use strict-format (#53444) #54939
config: must set line terminator when use strict-format (#53444) #54939
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Co-authored-by: D3Hunter <jujj603@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
This reverts commit b061557.
This reverts commit ac39786.
Signed-off-by: lance6716 <lance6716@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #54939 +/- ##
================================================
Coverage ? 71.2594%
================================================
Files ? 1465
Lines ? 422253
Branches ? 0
================================================
Hits ? 300895
Misses ? 100916
Partials ? 20442
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
1 similar comment
/retest |
This is an automated cherry-pick of #53444
What problem does this PR solve?
Issue Number: close #37338
Problem Summary:
What changed and how does it work?
as title
Check List
Tests
manually check it from a oncall ticket
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.