Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infosync: correct the PD API call of GetLabelRules (#55189) #55197

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #55189

What problem does this PR solve?

Issue Number: close #55188.

What changed and how does it work?

Correct the PD API call of GetLabelRules to GetRegionLabelRulesByIDs.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

SQL:

mysql> CREATE TABLE t (
    ->   a INT
    -> )
    -> PARTITION BY RANGE (a) (
    ->   PARTITION p0 VALUES LESS THAN (10)
    -> );
Query OK, 0 rows affected (0.04 sec)

mysql> ALTER TABLE t ATTRIBUTES 'merge_option=deny';
Query OK, 0 rows affected (0.03 sec)

mysql> ALTER TABLE t PARTITION p0 ATTRIBUTES 'merge_option=allow';
Query OK, 0 rows affected (0.03 sec)

mysql> ALTER TABLE t REMOVE PARTITIONING;
Query OK, 0 rows affected (0.20 sec)

mysql> SELECT * FROM information_schema.attributes WHERE attributes LIKE '%merge_option%';
Empty set (0.00 sec)

Before:

image

After:

image

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Aug 5, 2024
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 5, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 5, 2024
@JmPotato
Copy link
Member

JmPotato commented Aug 5, 2024

/retest-required

@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Aug 5, 2024
@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 5, 2024
Copy link

ti-chi-bot bot commented Aug 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-05 10:47:43.170645389 +0000 UTC m=+262593.037744478: ☑️ agreed by JmPotato.
  • 2024-08-05 12:15:42.420504231 +0000 UTC m=+267872.287603320: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 5, 2024
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot removed the approved label Aug 5, 2024
Copy link

ti-chi-bot bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, okJiang, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@e0ab246). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #55197   +/-   ##
================================================
  Coverage               ?   71.1733%           
================================================
  Files                  ?       1466           
  Lines                  ?     422675           
  Branches               ?          0           
================================================
  Hits                   ?     300832           
  Misses                 ?     101329           
  Partials               ?      20514           
Flag Coverage Δ
unit 71.1733% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.2982% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit 891151b into pingcap:release-8.1 Aug 5, 2024
18 checks passed
@JmPotato JmPotato deleted the cherry-pick-55189-to-release-8.1 branch August 5, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants