Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: update dumpling build options (#41165) #55350

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #41165

What problem does this PR solve?

Issue Number: close #55349

Problem Summary:

What is changed and how it works?

after upgrade a dependency in #41111, macOS must turn on cgo to build

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
manually make build_dumpling on macOS

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 12, 2024
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Aug 12, 2024
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-41165-to-release-6.5 branch from 68b57fd to cae7013 Compare August 12, 2024 02:40
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 12, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 12, 2024
Copy link

ti-chi-bot bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 12, 2024
Copy link

ti-chi-bot bot commented Aug 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-12 02:43:47.300356363 +0000 UTC m=+149512.003826003: ☑️ agreed by lance6716.
  • 2024-08-12 02:45:47.013600194 +0000 UTC m=+149631.717069838: ☑️ agreed by D3Hunter.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.5@3ea0661). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #55350   +/-   ##
================================================
  Coverage               ?   73.6194%           
================================================
  Files                  ?       1096           
  Lines                  ?     352335           
  Branches               ?          0           
================================================
  Hits                   ?     259387           
  Misses                 ?      76269           
  Partials               ?      16679           

@ti-chi-bot ti-chi-bot bot merged commit aa09937 into pingcap:release-6.5 Aug 12, 2024
10 checks passed
@wuhuizuo wuhuizuo deleted the cherry-pick-41165-to-release-6.5 branch August 12, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants