Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: add test for #54421 #55571

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Aug 21, 2024

What problem does this PR solve?

Issue Number: ref #54418

Problem Summary:
add test

What changed and how does it work?

add test

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Aug 21, 2024
Copy link

tiprow bot commented Aug 21, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.4670%. Comparing base (c1c74b1) to head (218de1c).
Report is 44 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55571        +/-   ##
================================================
+ Coverage   72.8739%   76.4670%   +3.5930%     
================================================
  Files          1576       1585         +9     
  Lines        440775     457545     +16770     
================================================
+ Hits         321210     349871     +28661     
+ Misses        99821      87044     -12777     
- Partials      19744      20630       +886     
Flag Coverage Δ
integration 51.6670% <ø> (?)
unit 72.7801% <ø> (-0.0929%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 64.8191% <ø> (+18.8731%) ⬆️

@Leavrth
Copy link
Contributor Author

Leavrth commented Aug 22, 2024

/retest

Copy link

tiprow bot commented Aug 22, 2024

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor Author

Leavrth commented Aug 22, 2024

/retest

Copy link

tiprow bot commented Aug 22, 2024

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 22, 2024
Copy link

ti-chi-bot bot commented Aug 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 26, 2024
Copy link

ti-chi-bot bot commented Aug 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-22 06:15:22.147463632 +0000 UTC m=+418917.281913769: ☑️ agreed by YuJuncen.
  • 2024-08-26 06:33:32.022442965 +0000 UTC m=+765607.156893085: ☑️ agreed by 3pointer.

@Leavrth
Copy link
Contributor Author

Leavrth commented Aug 26, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Aug 26, 2024
@Leavrth
Copy link
Contributor Author

Leavrth commented Aug 26, 2024

/retest

1 similar comment
@Leavrth
Copy link
Contributor Author

Leavrth commented Aug 27, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 290dc46 into pingcap:master Aug 27, 2024
36 of 40 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 27, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #55678.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants