*: bump client-go to fix correctness issue of membuffer snapshot read (#55547) #55626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
ti-chi-bot
added
ok-to-test
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
bot
added
size/XL
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> update client-go Signed-off-by: you06 <you1474600@gmail.com>
you06
force-pushed
the
cherry-pick-55547-to-release-6.5
branch
from
bfcc144
to
fa4907d
Compare
ti-chi-bot
bot
added
size/XXL
Signed-off-by: you06 <you1474600@gmail.com>
ti-chi-bot
bot
added
size/M
|
/retest |
1 similar comment
|
/retest |
zyguan
approved these changes
Sep 10, 2024
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #55626 +/- ##
================================================
Coverage ? 73.6264%
================================================
Files ? 1097
Lines ? 352812
Branches ? 0
================================================
Hits ? 259763
Misses ? 76334
Partials ? 16715 |
ekexium
approved these changes
Sep 10, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekexium, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
you06
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #55547
What problem does this PR solve?
Issue Number: close #54929
Problem Summary:
What changed and how does it work?
Fix the issue that mem buffer don't bypass the staging data when doing snapshot read and add a regression test.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.